The 'Call Super' Antipattern

A common design problem that is usually solved using the 'Call Super' antipattern (also referred to as code-smell). Simply stated, the problem occurs when the subclass needs to share the implementation of the super classes over-ridable methods.

In such case, 'Call Super' anti-patten is usually used by calling the over-ridden methods from within the subclass's over-riding methods.

I'll show a 'Call Super' code sample, then show a much better and neater solution (proposed by Martin Fowler).

The Bad Solution (Using the 'Call Super' AntiPattern):

class Penguin {
public void intoduceYourSelf() {
        System.out.println("Hi, I'm classified as a penguin.");
    }
}

class EmperorPenguin Extended Penguin {
    public void introduceYourSelf() {
        super.introduceYourSelf();
        System.out.println("My real name is Emperor Penguin");
    }
}

A Better Solution
A much better solution is to have an abstract method in the super class for the extra actions the subclasses will perform. And thus, the subclass only needs to implement that abstract method:

class Penguin {
    public void introduceYourSelf() {
        System.out.println("Hi, I'm classified as a penguin.");
        talkAboutYourselfMore();
    }
 

    abstract public talkAboutYourselfMore();
}


class EmperorPenguin extends Penguin {
    public void talkAboutYourselfMore() {
        System.out.println("My real name is Emperor Penguin");
    }
}

Thats it. A neat alternative solution that I love to use.